Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

Update: added handler for AsExpression TS node.kind #22

Closed
wants to merge 1 commit into from
Closed

Update: added handler for AsExpression TS node.kind #22

wants to merge 1 commit into from

Conversation

valorkin
Copy link

In typescript you can give a hint to tsc about variable type
using keyword as

(node as ts.BinaryExpression).operatorToken;
currently it throws an exception

@nzakas
Copy link
Member

nzakas commented Mar 11, 2016

Same comment as the other PR: please follow the regular ESLint pull request guidelines (http://eslint.org/docs/developer-guide/contributing/pull-requests)

In this case, we'd need an issue reference and the commit summary format to be updated.

@valorkin valorkin changed the title Feat: ast-converter, added case for as in implicit type convertion Update: added handler for AsExpression TS node.kind Mar 11, 2016
@nzakas
Copy link
Member

nzakas commented Mar 11, 2016

The output from this code is incorrect. Also, please don't add additional files that aren't related to the issue you're trying to fix.

Let's discuss back on #25 what the correct output should be.

@valorkin
Copy link
Author

Also, please don't add additional files that aren't related to the issue you're trying to fix.

@nzakas .editorconfig or ignoring IDE files?
or fixtures?

@nzakas
Copy link
Member

nzakas commented Mar 11, 2016

.editorconfig mostly.

@valorkin
Copy link
Author

@nzakas ok, I can create mega PR with .editorconfig
or you have something agains this config?

@nzakas
Copy link
Member

nzakas commented Mar 11, 2016

It should just be in a separate PR, since I can't merge this one due to what I said on #25.

@nzakas
Copy link
Member

nzakas commented Mar 18, 2016

Closing per discussion on #25.

@nzakas nzakas closed this Mar 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants